refactor: strict validation from bytes bloom filter - #516
Merged
leerho merged 2 commits intoAug 31, 2026
Merged
Conversation
Member
|
I would really appreciate it if you could check the Java Implementation too. I really want to keep Java and C++ implementations closely aligned. Thank you. |
leerho
approved these changes
Aug 31, 2026
leerho
left a comment
leerho
left a comment
Member
There was a problem hiding this comment.
Please also check Java and GO, I don't want them to diverge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following Rust implementation, strict validation makes sense to me.
Although adding private function to header is not API / ABI breaking change, But i want small changes to class, so i add to new static function.