fix: scope information schema to catalog - #24200
Open
VaibhaveS wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Catalog-qualified information schema queries currently return metadata from every registered catalog.
For example,
my_catalog.information_schema.tablesshould describe onlymy_catalog, consistent with PostgreSQL's information schema representing the current database.What changes are included in this PR?
InformationSchemaProvidernow receives one resolved catalog directly. Tables, columns, views, and schemas are enumerated only from that catalog.Unqualified
information_schemaqueries now use the configured default catalog instead of returning metadata from all catalogs.Are these changes tested?
Yes. Added multi-catalog SQL logic coverage for qualified and unqualified information schema queries.
Are there any user-facing changes?
Yes. Information schema results are now scoped to the resolved catalog.
The
InformationSchemaProvider::newsignature now accepts a catalog name andCatalogProvider.