Skip to content

fix: typo for the builder error type - #24052

Open
JosephLenton wants to merge 4 commits into
apache:mainfrom
JosephLenton:fix-plan-builder-data-type-error-typo
Open

fix: typo for the builder error type#24052
JosephLenton wants to merge 4 commits into
apache:mainfrom
JosephLenton:fix-plan-builder-data-type-error-typo

Conversation

@JosephLenton

@JosephLenton JosephLenton commented Aug 2, 2026

Copy link
Copy Markdown

Which issue does this PR close?

There is no ticket for this (I can open one if it is really needed). This is a very small nitpick QoL improvement, by changing the wording for an error.

The typo fixes the phrase ... can't cast to got ..., by adding a comma and making the rest a bit clearer.

Rationale for this change

  • The error doesn't read as natural english with ... can't cast to got ....
  • I've added more clarity on what got and for are, by changing to data of type and field of type.

What changes are included in this PR?

  • Rewording an error message.

Are these changes tested?

  • I added a test to confirm the error message looks right.

Are there any user-facing changes?

  • A user facing error message has changed.
  • No documentation changes are needed.
  • No API breaking changes are in this PR.

@github-actions github-actions Bot added the logical-expr Logical plan and expressions label Aug 2, 2026
@JosephLenton
JosephLenton force-pushed the fix-plan-builder-data-type-error-typo branch from 24b04be to 5a0c76f Compare August 2, 2026 11:01
@codecov-commenter

codecov-commenter commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.91%. Comparing base (3e3a92d) to head (7d82991).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24052      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files        1103     1103              
  Lines      377219   377230      +11     
  Branches   377219   377230      +11     
==========================================
- Hits       305244   305234      -10     
- Misses      53775    53793      +18     
- Partials    18200    18203       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephLenton
JosephLenton force-pushed the fix-plan-builder-data-type-error-typo branch from 445d9cb to bd7234c Compare August 3, 2026 15:53
@JosephLenton
JosephLenton marked this pull request as ready for review August 3, 2026 15:54

@nuno-faria nuno-faria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JosephLenton, I leave a small suggestion below.

Comment thread datafusion/expr/src/logical_plan/builder.rs Outdated
@JosephLenton

Copy link
Copy Markdown
Author

@nuno-faria I think you will need to approve this a second time please as I've pushed up your reword.

@nuno-faria

Copy link
Copy Markdown
Contributor

Thanks @JosephLenton, it's approved. Let's see if someone else has anything else to add before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants