fix: report Input column when native Iceberg scan is enabled or native shuffle is enabled - #5265
Open
hsiang-c wants to merge 4 commits into
Open
fix: report Input column when native Iceberg scan is enabled or native shuffle is enabled#5265hsiang-c wants to merge 4 commits into
Input column when native Iceberg scan is enabled or native shuffle is enabled#5265hsiang-c wants to merge 4 commits into
Conversation
hsiang-c
force-pushed
the
fix_iceberg_scan_input_size
branch
from
August 6, 2026 22:57
47de16e to
e103ba1
Compare
hsiang-c
marked this pull request as ready for review
August 6, 2026 23:01
hsiang-c
changed the title
Input column when native Iceberg scan is enabled or native shuffle is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5264
Rationale for this change
0.0Bfor theInputcolumn of the executor tab.What changes are included in this PR?
CometIcebergNativeScanExecis a sibling ofCometNativeScanExecunderCometLeafExec. So the old check only recognizes the Parquet leaf, andNativeExecContext.hasScanInputwas false for Iceberg (and CSV, and contributed Delta) scans.How are these changes tested?
Unit tests
SELECT id+1— scan fused under a native parent, parent'sdoExecuteColumnar→executeColumnarWithContextrepartition(4, id)— scan inlined under the writerRunning the same job again with the patch,
Inputcolumn show values now: