Skip to content

[6.2.x] feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x) - #2208

Merged
jbonofre merged 1 commit into
apache:activemq-6.2.xfrom
jbonofre:feat/1828-jmx-network-connector-uri-6.2.x
Jul 23, 2026
Merged

[6.2.x] feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x)#2208
jbonofre merged 1 commit into
apache:activemq-6.2.xfrom
jbonofre:feat/1828-jmx-network-connector-uri-6.2.x

Conversation

@jbonofre

@jbonofre jbonofre commented Jul 9, 2026

Copy link
Copy Markdown
Member

Backport of #1829 to the activemq-6.2.x branch.

Summary

  • Add getUri() and getLocalUri() to NetworkConnectorViewMBean so the network connector URI is visible via JMX.
  • Add abstract getUri() to the NetworkConnector base class.
  • Implement getUri() in MulticastNetworkConnector (delegates to getRemoteURI()).
  • DiscoveryNetworkConnector and LdapNetworkConnector already had getUri() implementations and satisfy the new abstract contract without changes.
  • Extend JmxCreateNCTest to assert the exposed URI values.

…Bean

Add getUri() and getLocalUri() attributes to NetworkConnectorViewMBean so
that the network connector URI is visible via JMX. Add abstract getUri() to
NetworkConnector base class and implement it in MulticastNetworkConnector.

Backport of apache#1829 to activemq-6.2.x.
@jbonofre jbonofre changed the title feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x) Jul 9, 2026
@mattrpav

mattrpav commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

nit: Once v6.3.0 we should tighten up our back-port policies to not back-port new fields.

@mattrpav mattrpav changed the title feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x) [6.2.x] feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x) Jul 9, 2026
@jbonofre

jbonofre commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@mattrpav it's not breaking change as it's new fields. I'm fine to close it, but adding fields or features that don't impact (breaking change) is reasonable to me. That said, as 6.3.0 is coming 😄 let me close this backport one.

@jbonofre jbonofre closed this Jul 9, 2026
@mattrpav

mattrpav commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@jbonofre no need to close this, esp since 6.3.x has taken a while to get out. This is minor, but I think we need to clarify for going forward. Adding a metric to a network connector isn't a big deal, but a config flag to queue or kahadb could be. Changing bin/setenv OPTS variables, causes admins to have to re-work packaging bundles b/w point releases, etc.

So I think 'adding a field' can be too reductive and over arching.

Keep this one for 6.2.x, I think we need clarify and possibly add a SEMVER.md for clarity all around

@jbonofre jbonofre reopened this Jul 10, 2026
@jbonofre

Copy link
Copy Markdown
Member Author

@mattrpav agree. This PR is similar to the one you did (#2239 ). So, let revisit once 6.3.0 is out.

@jbonofre
jbonofre merged commit 5f339c9 into apache:activemq-6.2.x Jul 23, 2026
6 of 8 checks passed
@jbonofre
jbonofre deleted the feat/1828-jmx-network-connector-uri-6.2.x branch July 23, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants