fix(server): await catalog readiness for reads#36131
Open
harshmathurx wants to merge 1 commit into
Open
Conversation
8 tasks
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
Hi @kitlangton — pinging you on this since it's been a couple of days with no maintainer response. The issue is linked in the PR description and all automated checks are green, but the PR is still waiting on review/merge. Could you take a look when you have a chance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36117
Type of change
What does this PR do?
Makes the public catalog read handlers wait for the existing plugin readiness barrier before returning successful catalog snapshots:
/api/modelnow waits for the same bounded catalog readiness path as/api/model/default./api/providerand/api/provider/{providerID}also wait for plugin readiness before reading provider availability.ServiceUnavailableErrorinstead of returning a successful partial catalog.This keeps cold-start provider/model reads from treating intermediate plugin/catalog state as authoritative.
@kitlangton tagging you since you authored the issue and the repro. Could you assign #36117 to me if this matches the intended fix direction?
How did you verify your code works?
git diff --check.packages/server; this branch does not currently includetest/catalog-readiness.test.ts, so Bun reported that the filter matched no files.bun run typecheckfrompackages/server; blocked locally because dependencies/tooling are unavailable (tsgo: command not found) after the repo dependency install is blocked by the private/403ghostty-webdependency.Screenshots / recordings
N/A
Checklist