Skip to content

refactor(form): model links as fields#36129

Merged
rekram1-node merged 15 commits into
v2from
form-schemas
Jul 10, 2026
Merged

refactor(form): model links as fields#36129
rekram1-node merged 15 commits into
v2from
form-schemas

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • model URL requests as external fields within the shared form schema
  • support opening, copying, manually completing, and acknowledging external fields in the TUI
  • require external fields to be acknowledged before form submission
  • require forms and question tool calls to contain at least one field
  • immediately accept MCP form elicitations with empty schemas instead of creating empty UI state
  • regenerate client types and update form fixtures and contract coverage

Testing

  • bun test test/mcp.test.ts test/form.test.ts test/tool-question.test.ts in packages/core
  • bun test test/contract-hygiene.test.ts in packages/schema
  • bun test test/cli/tui/data.test.tsx test/cli/tui/form.test.tsx test/cli/cmd/tui/notifications.test.ts in packages/tui
  • bun test in packages/client
  • bun typecheck in packages/core, packages/schema, packages/protocol, packages/server, packages/client, packages/tui, and packages/sdk/js
  • bun turbo typecheck --concurrency=3

@rekram1-node
rekram1-node merged commit a6449cb into v2 Jul 10, 2026
8 checks passed
@rekram1-node
rekram1-node deleted the form-schemas branch July 10, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant