fix(tui): cycle model variants from default#36096
Closed
tobwen wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36095
Type of change
What does this PR do?
This PR fixes TUI variant cycling when a model defines a real variant named
default. The cycle logic now uses a non-default cycle order internally, soctrl+tmoves through configured variants such ashigh,max, andnonebefore returning to the default state.The previous logic used the full variant list. Because
set(undefined)storesdefault, a list likehigh,max,default, andnonemade the cycle jump fromdefaulttonone, then back todefault. The visible variant list and dialog behavior are unchanged.How did you verify your code works?
nextVariantInCyclewithhigh,max,default, andnone.defaultreturnednoneinstead ofhigh.bun test test/context/local.test.tsfrompackages/tui.bun typecheckfrompackages/tui.bun run build -- --singlefrompackages/opencodeand confirmed the build smoke test passed.ctrl+tcycles throughdefault,high,max, andnonefor the affected model.Screenshots / recordings
Not included. The change affects keyboard cycling behavior in the TUI.
Checklist