fix(tui): normalize carriage returns in question text#36088
Open
umi008 wants to merge 1 commit into
Open
Conversation
Models that emit \r characters in question strings cause the TUI to render one word per line. Strip carriage returns in parseQuestions before passing text to the renderer. Fixes anomalyco#36040
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36040
Type of change
What does this PR do?
Some LLMs emit question strings containing
\r(carriage return) characters. TheparseQuestionsfunction in the TUI split on newlines but did not strip\r, causing each word to render on its own line. Added.replace(/\r/g, "")to normalize the text before parsing.How did you verify your code works?
tsgo --noEmitpasses frompackages/tuiChecklist