fix(acp): allow v2 initialize with future params - #304
Merged
Conversation
benbrandt
enabled auto-merge (squash)
July 28, 2026 19:10
Merge current main into the v2 initialize work, keep fallback reuse lossless, and canonicalize future protocol requests through the selected v2 schema.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2::conversionhelpersDesign
ACP traffic remains version-specific after initialization. The private adapter covers only the initialize negotiation boundary, where the router has enough context to define the mapping. This prepares the SDK for the upstream removal of broad v1/v2 conversion helpers without making conversion failure a protocol failure.
Verification
just testcargo clippy -p agent-client-protocol --all-targets --all-features -- -D warningscargo check -p agent-client-protocol --no-default-features --features unstable_protocol_v2