Skip to content

fix(acp): allow v2 initialize with future params - #304

Merged
benbrandt merged 2 commits into
mainfrom
initialize-change
Aug 5, 2026
Merged

fix(acp): allow v2 initialize with future params#304
benbrandt merged 2 commits into
mainfrom
initialize-change

Conversation

@benbrandt

@benbrandt benbrandt commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

  • treat v2-to-v1 initialize projection as an optional connection-reuse probe, so valid v2 traffic is not rejected when projection is unavailable
  • reuse a fallback connection only when the projected v2 parameters exactly match the v1 implementation; otherwise reconnect and initialize cleanly
  • preserve raw extension fields for exact-version requests while canonicalizing future protocol versions through the selected schema
  • remove SDK tests and migration guidance that depend on the experimental schema-wide v2::conversion helpers

Design

ACP traffic remains version-specific after initialization. The private adapter covers only the initialize negotiation boundary, where the router has enough context to define the mapping. This prepares the SDK for the upstream removal of broad v1/v2 conversion helpers without making conversion failure a protocol failure.

Verification

  • just test
  • cargo clippy -p agent-client-protocol --all-targets --all-features -- -D warnings
  • cargo check -p agent-client-protocol --no-default-features --features unstable_protocol_v2
  • focused initialize-normalization and protocol-v2 tests

@benbrandt
benbrandt enabled auto-merge (squash) July 28, 2026 19:10
Merge current main into the v2 initialize work, keep fallback reuse lossless, and canonicalize future protocol requests through the selected v2 schema.
@benbrandt benbrandt changed the title fix(acp): Allow v2 initialize with future params fix(acp): allow v2 initialize with future params Aug 5, 2026
@benbrandt
benbrandt merged commit d039e74 into main Aug 5, 2026
14 checks passed
@benbrandt
benbrandt deleted the initialize-change branch August 5, 2026 18:03
@acp-release-bot acp-release-bot Bot mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant