Fix Python 3.14 custom demangler dispatch - #8391
Open
plafosse wants to merge 1 commit into
Open
Conversation
plafosse
force-pushed
the
test_fix_python314_demangler_bug
branch
from
August 5, 2026 21:43
4cf083f to
de19c77
Compare
plafosse
force-pushed
the
test_fix_python314_demangler_bug
branch
from
August 6, 2026 03:06
de19c77 to
69ca12a
Compare
fuzyll
approved these changes
Aug 6, 2026
fuzyll
left a comment
fuzyll
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this up! I've confirmed that, with the core change to make this work with a unit test, this no longer breaks on 3.14. Approved. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does two things. Most importantly it fixes a run time error which occurred in the legacy demangler plugin detection code when run under python 3.14. Python 3.13 and below were fine. Second it moves the legacy detection code up to registration improving perf.