WIP - Ember Table Implementation#6397
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Port the Lit basic-external-state example to Ember, demonstrating external management of sorting and pagination state via @Tracked properties and onSortingChange/onPaginationChange handlers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: bad object first arg
4aaf1e6 to
e83347d
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
🎯 Changes
This PR is the initial proposed implementation for an Ember.js adapter for Tanstack Table.
This is heavily based on Lit with learnings from the Angular implementation since Ember patterns and public signals API lay somewhere between these two frameworks.
This replaces previous work #6362
Based on thread from Discord between @rtablada @KevinVandy and @NullVoxPopuli this implements the state reactivity and flex-render.
✅ Checklist
pnpm test:pr.Notes
Currently this is set up with a
demo-appwhich includes all of the Ember examples. This is used for regression testing as the internal reactivity is worked on. It keeps it so that I can work on validating the examples while not needing 10+ vite apps running on top of the raw rollup build for package internals.