Resize fix - #741
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates main-page UI refresh logic so that when the UI re-renders on environment/layout changes (e.g., mobile resize), it restores the correct subject URI for panes whose subject is not the current page URL—preventing state/data from being lost due to rendering the wrong subject.
Changes:
- Read
paneUrifromwindow.history.stateand use it as theGotoSubjecttarget forprofile,social, andfolderpanes. - Keep existing behavior (use
document.location.href) for panes that use the page URL as their subject.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+68
to
+69
| // Panes rendered for a subject other than the page URL (storage/profile/social) | ||
| // must be restored from paneUri, since byName() returns the pane without that subject. |
timea-solid
approved these changes
Aug 19, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
I looked at it in attention. I believe this is a goos imporvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue where on mobile the data gets lost.