Skip to content

Fix MSVC warnings in Corsair Wireless V2 support - #564

Merged
Sapd merged 2 commits into
Sapd:masterfrom
ChrisLauinger77:fix/msvc-corsair-void-v2w-warnings
Aug 22, 2026
Merged

Fix MSVC warnings in Corsair Wireless V2 support#564
Sapd merged 2 commits into
Sapd:masterfrom
ChrisLauinger77:fix/msvc-corsair-void-v2w-warnings

Conversation

@ChrisLauinger77

Copy link
Copy Markdown
Contributor

Summary

  • mark the intentionally unused capability parameter with [[maybe_unused]]
  • request uint16_t output explicitly from map()
  • retain the unsigned rounding result and explicitly extract its two HID bytes
  • correct the sidetone mapping comment to the actual 0-1000 range

This addresses the C4100 and C4244 warnings emitted by MSVC when HeadsetControl is built as a QontrolPanel submodule.

Validation

  • cmake --build build --target check -j2
  • 2/2 tests passed
  • git diff --check

@Sapd
Sapd merged commit 08c9e65 into Sapd:master Aug 22, 2026
6 checks passed
@ChrisLauinger77
ChrisLauinger77 deleted the fix/msvc-corsair-void-v2w-warnings branch August 22, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants