Avoid data.table:: for tests to work more reliably under cc() - #7876
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7876 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17292 17292
=======================================
Hits 17122 17122
Misses 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the installed version of {data.table} is still in a weird state,
data.table::here will reference it and cause some confusing issues.Better to use the value of
fread()resolved in the current session.This is the only call site with the issue; there are other
data.table::in the file, but all are being intercepted by NSE and thus ignored:https://github.com/Rdatatable/data.table/blob/914dd14bfddb08e53d625be21ceb0f2e65594c85/inst/tests/tests.Rraw#L18102-L18104
Merging as pretty inconsequential. cc @aitap as the author for FYI