Skip to content

Avoid data.table:: for tests to work more reliably under cc() - #7876

Merged
MichaelChirico merged 1 commit into
masterfrom
tests-cc
Aug 3, 2026
Merged

Avoid data.table:: for tests to work more reliably under cc()#7876
MichaelChirico merged 1 commit into
masterfrom
tests-cc

Conversation

@MichaelChirico

@MichaelChirico MichaelChirico commented Aug 3, 2026

Copy link
Copy Markdown
Member

If the installed version of {data.table} is still in a weird state, data.table:: here will reference it and cause some confusing issues.

Better to use the value of fread() resolved in the current session.

This is the only call site with the issue; there are other data.table:: in the file, but all are being intercepted by NSE and thus ignored:

https://github.com/Rdatatable/data.table/blob/914dd14bfddb08e53d625be21ceb0f2e65594c85/inst/tests/tests.Rraw#L18102-L18104

Merging as pretty inconsequential. cc @aitap as the author for FYI

@MichaelChirico
MichaelChirico merged commit 561a869 into master Aug 3, 2026
6 checks passed
@MichaelChirico
MichaelChirico deleted the tests-cc branch August 3, 2026 20:55
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (7bc8bc1) to head (4983a88).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7876   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17292    17292           
=======================================
  Hits        17122    17122           
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant