Skip to content

test: Reenable a variety of skipped tests #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 2 commits into from
Aug 28, 2026
Merged

test: Reenable a variety of skipped tests #10320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe3a00
test: Reenable a variety of skipped tests
gonfunko Aug 25, 2026
e3102ea
Merge branch 'main' into skip-to-my-lou
gonfunko Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/blockly/tests/mocha/blocks/procedures_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,12 +615,6 @@ suite('Procedures', function () {
);
});

test.skip(
'renaming a variable such that you get a parameter ' +

@maribethb maribethb Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough to remove this but we probably should have a test for this behavior assuming we ever decided what the behavior should be lol, might be worth siccing the llm on it

@gonfunko gonfunko Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the deciding what should happen is the issue. Presently it just does nothing (the variable name goes through, and becomes the same variable as the param) which I think is fine?

'conflict does... something!',
function () {},
);

test('undoing renaming a procedure parameter reverts the change', async function () {
// Create a stack of container, parameter.
const defBlock = createProcDefBlock(this.workspace);
Expand Down Expand Up @@ -1046,10 +1040,13 @@ suite('Procedures', function () {
);
});

test.skip('callers whose defs are deserialized later do not create defs', function () {
test('callers whose defs are deserialized later do not create defs', function () {
Blockly.Xml.domToWorkspace(
Blockly.utils.xml.textToDom(`
<xml>
<variables>
<variable id="arg">x</variable>
</variables>
<block type="procedures_callreturn">
<mutation name="do something">
<arg name="x"></arg>
Expand All @@ -1072,8 +1069,6 @@ suite('Procedures', function () {
const callBlock = this.workspace.getBlocksByType(
'procedures_callreturn',
)[0];
// TODO: Currently the callers are creating variables with different
// IDs than those serialized to XML, so these assertions fail.
assertDefBlockStructure(defBlock, true, ['x'], ['arg']);
assertCallBlockStructure(callBlock, ['x'], ['arg'], 'do something');
});
Expand Down Expand Up @@ -1188,7 +1183,7 @@ suite('Procedures', function () {
);
});

test.skip('callers whose defs are deserialized later do not create defs', function () {
test('callers whose defs are deserialized later do not create defs', function () {
Blockly.serialization.workspaces.load(
{
'blocks': {
Expand All @@ -1197,6 +1192,7 @@ suite('Procedures', function () {
{
'type': 'procedures_callreturn',
'extraState': {
'name': 'do something',
'params': ['x'],
},
},
Expand All @@ -1216,6 +1212,12 @@ suite('Procedures', function () {
},
],
},
'variables': [
{
'name': 'x',
'id': 'arg',
},
],
},
this.workspace,
);
Expand All @@ -1226,8 +1228,6 @@ suite('Procedures', function () {
const callBlock = this.workspace.getBlocksByType(
'procedures_callreturn',
)[0];
// TODO: Currently the callers are creating variables with different
// IDs than those serialized to JSON, so these assertions fail.
assertDefBlockStructure(defBlock, true, ['x'], ['arg']);
assertCallBlockStructure(callBlock, ['x'], ['arg'], 'do something');
});
Expand Down
6 changes: 2 additions & 4 deletions packages/blockly/tests/mocha/input_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,7 @@ suite('Inputs', function () {
setBlockSpy.restore();
initSpy.restore();
});
// TODO: InsertFieldAt does not properly handle initialization in
// headless mode.
test.skip('Headless', function () {
test('Headless', function () {
const field = new Blockly.FieldLabel('field');
const setBlockSpy = sinon.spy(field, 'setSourceBlock');
const initModelSpy = sinon.spy(field, 'initModel');
Expand Down Expand Up @@ -351,7 +349,7 @@ suite('Inputs', function () {

assert.include(label, customLabel);
});
test.skip('Set input ARIA Label Provider to null', function () {
test('Set input ARIA Label Provider to null', function () {
const blockA = createRenderedBlock(this.workspace, 'row_block');
const blockB = createRenderedBlock(this.workspace, 'row_block');

Expand Down
256 changes: 0 additions & 256 deletions packages/blockly/tests/mocha/old_workspace_comment_test.js
View file
Open in desktop

This file was deleted.

Loading