Skip to content

[components][spi] add utest cases#11549

Open
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:feat_spi_utest
Open

[components][spi] add utest cases#11549
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:feat_spi_utest

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

为什么提交这份PR (why to submit this PR)

本 PR 为 SPI 驱动补充 utest 覆盖，便于在支持 SPI 的 BSP 上验证 MOSI/MISO 回环传输以及 SPI Flash SFUD 读写流程。此前 SPI 驱动缺少对应的组件级用例，回环测试的矩阵配置项也较多，使用和定位问题都不够直接。

你的解决方案是什么 (what is your solution)

  • 在 components/drivers/spi/utest 下新增 SPI loopback 和 SPI flash utest。
  • loopback 用例覆盖 sendrecv8、transfer、transfer_message，并根据最大频率和最大数据长度自动生成测试矩阵。
  • loopback 失败时输出实际频率、首个不匹配字节，并在基础 byte 回环失败后跳过该频率下的长包矩阵，减少重复断言。
  • SPI flash 用例通过 SFUD 进行擦写读校验，并在测试前备份、测试后恢复目标区域。
  • SPI flash 探测频率改为可配置项，默认 10MHz，并在 SFUD probe 前输出 raw JEDEC ID 方便定位硬件连接、频率或型号问题。
  • 为 GD32F527 EVB 和 STM32F407 RT-Spark 增加 SPI utest 的 CI attach 配置，覆盖本次实测的板级 SPI 组合。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

    • bsp/gd32/arm/gd32527I-eval (GD32F527)
    • bsp/stm32/stm32f407-rt-spark

  • .config for bsp/gd32/arm/gd32527I-eval:

    • CONFIG_BSP_USING_SPI=y
    • CONFIG_BSP_USING_SPI5=y
    • CONFIG_RT_USING_UTESTCASES=y
    • CONFIG_RT_CONSOLEBUF_SIZE=256
    • CONFIG_RT_UTEST_SPI_LOOPBACK=y
    • CONFIG_RT_UTEST_SPI_LOOPBACK_BUS_NAME="spi5"
    • CONFIG_RT_UTEST_SPI_LOOPBACK_DEV_NAME="spi_loop"
    • CONFIG_RT_UTEST_SPI_LOOPBACK_DATA_SIZE=512
    • CONFIG_RT_UTEST_SPI_LOOPBACK_MAX_HZ=10000000
    • CONFIG_RT_UTEST_SPI_LOOPBACK_API_SMOKE=y
    • CONFIG_RT_UTEST_SPI_FLASH=y
    • CONFIG_RT_UTEST_SPI_FLASH_SPI_DEV_NAME="spi50"
    • CONFIG_RT_UTEST_SPI_FLASH_BUS_NAME="spi5"
    • CONFIG_RT_UTEST_SPI_FLASH_CS_PIN=136
    • CONFIG_RT_UTEST_SPI_FLASH_DEV_NAME="GD25Q16B"
    • CONFIG_RT_UTEST_SPI_FLASH_MAX_HZ=10000000

  • .config for bsp/stm32/stm32f407-rt-spark:

    • CONFIG_BSP_USING_SPI=y
    • CONFIG_BSP_USING_SPI1=y
    • CONFIG_BSP_USING_SPI2=y
    • CONFIG_RT_USING_UTESTCASES=y
    • CONFIG_RT_CONSOLEBUF_SIZE=256
    • CONFIG_RT_UTEST_SPI_LOOPBACK=y
    • CONFIG_RT_UTEST_SPI_LOOPBACK_BUS_NAME="spi1"
    • CONFIG_RT_UTEST_SPI_LOOPBACK_DEV_NAME="spi_loop"
    • CONFIG_RT_UTEST_SPI_LOOPBACK_DATA_SIZE=512
    • CONFIG_RT_UTEST_SPI_LOOPBACK_MAX_HZ=10000000
    • CONFIG_RT_UTEST_SPI_LOOPBACK_API_SMOKE=y
    • CONFIG_RT_UTEST_SPI_FLASH=y
    • CONFIG_RT_UTEST_SPI_FLASH_SPI_DEV_NAME="spi20"
    • CONFIG_RT_UTEST_SPI_FLASH_BUS_NAME="spi2"
    • CONFIG_RT_UTEST_SPI_FLASH_CS_PIN=28
    • CONFIG_RT_UTEST_SPI_FLASH_DEV_NAME="W25Q64"
    • CONFIG_RT_UTEST_SPI_FLASH_MAX_HZ=10000000

  • CI attach:

    • bsp/gd32/arm/gd32527I-eval/.ci/attachconfig/ci.attachconfig.yml, project: utest.spi
    • bsp/stm32/stm32f407-rt-spark/.ci/attachconfig/ci.attachconfig.yml, project: utest.spi

  • action: 已推送 PR，等待 GitHub PR CI 验证。

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：feat_spi_utest
  • 设置PR number为 \ Set the PR number to：11549
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 feat_spi_utest 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat_spi_utest branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_rt-spark

Reviewers: @Rbb666 @kurisaW

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/.ci/attachconfig/ci.attachconfig.yml

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/.ci/attachconfig/ci.attachconfig.yml

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/spi/SConscript
  • components/drivers/spi/utest/Kconfig
  • components/drivers/spi/utest/SConscript
  • components/drivers/spi/utest/spi_flash_tc.c
  • components/drivers/spi/utest/spi_loopback_tc.c
  • components/utilities/utest/Kconfig

🏷️ Tag: components_driver_spi

Reviewers: @Liang1795 @wdfk-prog

Changed Files (Click to expand)
  • components/drivers/spi/SConscript
  • components/drivers/spi/utest/Kconfig
  • components/drivers/spi/utest/SConscript
  • components/drivers/spi/utest/spi_flash_tc.c
  • components/drivers/spi/utest/spi_loopback_tc.c

📊 Current Review Status (Last Updated: 2026-07-02 16:41 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3 CYFS3 marked this pull request as ready for review July 2, 2026 03:41
@CYFS3 CYFS3 mentioned this pull request Jul 2, 2026
Open
34 tasks
@CYFS3 CYFS3 force-pushed the feat_spi_utest branch from ce1d502 to e2f52a3 Compare July 2, 2026 03:49
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@CYFS3

CYFS3 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

GD32F527
GD25Q16B
image

回环测试
image

@CYFS3

CYFS3 commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

星火一号
w25q64
image

@CYFS3 CYFS3 force-pushed the feat_spi_utest branch from e2f52a3 to eb60f08 Compare July 2, 2026 05:23
@CYFS3 CYFS3 requested a review from kurisaW as a code owner July 2, 2026 05:23
@github-actions github-actions Bot added BSP BSP: GD32 BSP related with GD32 labels Jul 2, 2026
@CYFS3 CYFS3 force-pushed the feat_spi_utest branch from eb60f08 to 4d5a471 Compare July 2, 2026 05:29
@CYFS3 CYFS3 requested a review from Rbb666 as a code owner July 2, 2026 05:29
@github-actions github-actions Bot added the BSP: STM32 BSP related with ST/STM32 label Jul 2, 2026
@CYFS3 CYFS3 force-pushed the feat_spi_utest branch from 4d5a471 to 8866935 Compare July 2, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner
@Rbb666 Rbb666 Awaiting requested review from Rbb666 Rbb666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BSP: GD32 BSP related with GD32 BSP: STM32 BSP related with ST/STM32 BSP component: drivers/spi component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CYFS3