fix(site): use the animated mascot logo in the hero - #65
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe hero video and playback controls were removed from ChangesHero mascot migration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
commit: |
The hero played /pythinker-hero-clean-v2.mp4 through a play/pause button. That asset is gone from apps/site/public, so the site build failed outright: Rollup could not resolve the import. Render the existing PythinkerMascot component instead. It inlines the same artwork as public/pythinker_animated.svg (34 identical paths, the same blink, mouth, antenna-glow and eye-shine animations) and already carries its own scoped prefers-reduced-motion guard, so the video refs, the play/pause handlers and the mask/blend CSS all go away. Also drop four assets nothing references: the mp4, arctecture.webp, logo.png and brand/linux.svg.
elkaix
force-pushed
the
fix/site-hero-mascot-logo
branch
from
August 12, 2026 09:54
6db5769 to
7f8bf92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue. The problem is described below.
Problem
The landing page hero rendered
/pythinker-hero-clean-v2.mp4inside a play/pause<button>. That asset is no longer present inapps/site/public, sopnpm -C apps/site run buildfails outright onmain:What changed
PythinkerMascotcomponent instead of the video. It inlines the same artwork aspublic/pythinker_animated.svg— 34 identical<path>elements and the same four animations (blink, mouthTalk, antennaGlow, eyeShine) — and already ships a scopedprefers-reduced-motionguard, so no extra request and no new motion handling.heroVideo/heroVideoPlayingrefs,playHeroVideo,syncHeroMotionPreference,toggleHeroVideo, theirmatchMedialisteners, and the.hero-mascot-videorules (radial mask +mix-blend-mode: multiply).reducedMotionQuerystays — the reveal-on-scroll observer still uses it..hero-mascotsizes the logo atclamp(128px, 12vw, 164px), centered. The hero block is roughly 55px taller than the old 4:3 video, so content below shifts down slightly.pythinker-hero-clean-v2.mp4,arctecture.webp,logo.png,brand/linux.svg.Deliberately kept, because they are addressed by URL or convention rather than by an import:
_headers(Cloudflare Pages),bimi-logo.svg(DNS BIMI record),code/oauth-success.html(OAuth redirect landing page), andicon-192.png/icon-512.png.Verified:
pnpm -C apps/site run buildnow succeeds, andpnpm exec oxlint --type-aware apps/site/src/App.vueis clean.Checklist
apps/sitehas no test suite; the site build is the gate, and it goes from failing to passing with this change.gen-changesetsskill, or this PR needs no changeset.[skip changeset]— the only published package is@pythoughts/pythinker-code, and@pythoughts/siteis a private marketing site that does not enter the CLI bundle, so nothing here reaches a release artifact. No site-only change in this repo has ever carried a changeset.gen-docsskill, or this PR needs no doc update.Summary by CodeRabbit