fix: report dtype/ndim error when extracting PyReadonlyArray/PyReadwriteArray#562
Open
flying-sheep wants to merge 1 commit into
Open
fix: report dtype/ndim error when extracting PyReadonlyArray/PyReadwriteArray#562flying-sheep wants to merge 1 commit into
PyReadonlyArray/PyReadwriteArray#562flying-sheep wants to merge 1 commit into
Conversation
Icxolu
reviewed
Jul 21, 2026
Icxolu
left a comment
Icxolu
left a comment
Member
There was a problem hiding this comment.
You're right, we can do that for PyReadonlyArray and PyReadwriteArray as these are our types and we can control the FromPyObject implementation. It means that there is now a mismatch in error message between PyReadonlyArray/PyReadwriteArray and Bound<PyArray>, but given the advantage it's probably justified. (It also makes me less sad about the change to PyErr as this makes #560 basically free)
flying-sheep
force-pushed
the
fix-extract-msg
branch
from
July 22, 2026 06:42
5571b45 to
7ee1056
Compare
flying-sheep
force-pushed
the
fix-extract-msg
branch
from
July 22, 2026 06:42
7ee1056 to
064a0c4
Compare
Author
|
If you want a more semantic error, we could create a new error enum wrapping CastError, (D)TypeError, DimensionalityError, or BorrowError. I think that covers all of them. If you want I can also just roll #560 into this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561
Doesn’t address extracting
Bound<PyArray>because that’s truly impossible with pyo3’s current API.