chore(server): drop the unused question service type anchor - #88
Conversation
The runtime const existed only to keep the IQuestionService import referenced, and needed an eslint suppression to survive. The class already names the interface in a type position, so a type-only import carries it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe question service now imports ChangesQuestion service import cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes an unused runtime type anchor while preserving the interface's type-only usage; the localized cleanup is merge-ready after normal checks, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
commit: |
Related Issue
Follow-up to a review finding on #85, deliberately deferred there to keep that bug-fix PR free of
drive-by edits.
Problem
packages/server/src/services/question/questionService.tscarried:The const existed only to keep the
IQuestionServiceimport referenced at runtime, and it needed alint suppression to survive. Oxlint still reported
no-underscore-dangleon it.What changed
IQuestionServicemoves to a type-only import and the anchor plus its suppression are deleted. Theclass already names the interface in a type position (
implements IQuestionService), which is theonly reference this file needs.
Verification
Because the identifier is a DI decorator, a green typecheck alone would not prove the runtime
registration still works — so the full server suite was the gate:
pnpm --filter @pymodel/server exec vitest run— 503 passed (43 files).pnpm --filter @pymodel/server exec tsc -p tsconfig.json --noEmit— exit 0.pnpm run lint— exit 0.Checklist
gen-changesetsskill, or this PR needs no changeset. —@pymodel/serveris changeset-ignored.gen-docsskill, or this PR needs no doc update.Summary by CodeRabbit