Skip to content

docs: require pull requests for every change to main - #19

Merged
elkaix merged 1 commit into
mainfrom
chore/document-pr-only-main
Aug 5, 2026
Merged

docs: require pull requests for every change to main#19
elkaix merged 1 commit into
mainfrom
chore/document-pr-only-main

Conversation

@elkaix

@elkaix elkaix commented Aug 5, 2026

Copy link
Copy Markdown
Member

Related Issue

No issue — this documents a repository setting change made directly on GitHub.

Problem

main had branch protection, but enforce_admins was off and required approvals were 0. Admins
bypassed every rule, so changes were landing on main by direct push with no PR and no gate. The
constraint existed on paper but not in practice.

What changed

main branch protection now sets enforce_admins: true. Direct pushes are rejected for everyone,
admins included — verified by an empty commit that came back GH006: Changes must be made through a pull request.

Required approvals stay at 0 deliberately: the repository has a single collaborator, and
coderabbitai only ever submits COMMENTED reviews, never APPROVED. Requiring an approval would
make every self-authored PR permanently unmergeable. The gate is therefore PR + green checks +
resolved conversations rather than a human approval signature.

This PR records the rule in AGENTS.md, where the other workflow constraints live, and is itself
the first change to go through the new flow.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works. — documentation only, nothing executable
  • Ran gen-changesets skill, or this PR needs no changeset. — docs-only, no CLI bump
  • Ran gen-docs skill, or this PR needs no doc update.

Summary by CodeRabbit

  • Documentation
    • Added contribution guidelines requiring changes to be submitted through pull requests.
    • Documented requirements for passing checks, resolving review comments, and keeping branches up to date.

main now enforces branch protection for admins too, so a direct push is
rejected. Record the rule and the merge conditions where agents and
contributors already look for workflow constraints.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a84ce1d9-6a19-4b3a-b2b3-4d70517ec121

📥 Commits

Reviewing files that changed from the base of the PR and between d7a5db0 and 423762f.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

Added mandatory workflow rules for main. Changes must use pull requests, pass six named checks, resolve review conversations, and keep the branch up to date before merge.

Changes

Pull Request Workflow Rules

Layer / File(s) Summary
Main branch merge requirements
AGENTS.md
The workflow now prohibits direct or bypassed pushes to main. Merges require six named checks, resolved reviews, and an up-to-date branch.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required docs prefix, imperative mood, and clearly describes the main change within 72 characters.
Description check ✅ Passed The description includes all required sections and explains the repository change, validation, and why tests and a changeset are not needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 5, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@pythoughts/pythinker-code@423762f
npx https://pkg.pr.new/@pythoughts/pythinker-code@423762f

commit: 423762f

@elkaix
elkaix merged commit f670efe into main Aug 5, 2026
13 checks passed
@elkaix
elkaix deleted the chore/document-pr-only-main branch August 5, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant