Skip to content

fix: accept a punctuation-delimited reason on the RESULT line #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elkaix merged 1 commit into from
Aug 13, 2026
Merged

fix: accept a punctuation-delimited reason on the RESULT line #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/lib-write-turn.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ _write_turn_positive_integer() {

_write_turn_result_state() {
printf '%s\n' "$1" |
sed -nE 's/^RESULT:[[:space:]]*(DONE|NEEDS_ANSWERS|BLOCKED|FAILED)[[:space:]]*$/\1/p' |
sed -nE 's/^RESULT:[[:space:]]*(DONE|NEEDS_ANSWERS|BLOCKED|FAILED)([[:space:]]*[^[:alnum:]_[:space:]].*)?[[:space:]]*$/\1/p' |
tail -1
}
# Implementer contract — appended to every dispatch so each run is disciplined by
Expand Down
15 changes: 14 additions & 1 deletion tests/stop-report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@ printf 'Objective: fail closed when status is lost.\n' > "$STATUS_LOSS_PLAN"
printf 'Objective: carry failed evidence.\n' > "$FAILED_PLAN"
printf 'Objective: reject a result prefix.\n' > "$REPO/prefix-plan.md"
printf 'Objective: accept the last result record.\n' > "$REPO/last-record-plan.md"
printf 'Objective: accept a trailing result reason.\n' > "$REPO/reason-plan.md"
cp "$DONE_PLAN" "$TEST_ROOT/done-plan.before"
git init -q "$REPO"
(
cd "$REPO" &&
git config user.email p@p &&
git config user.name p &&
git add needs-plan.md done-plan.md status-loss-plan.md failed-plan.md prefix-plan.md last-record-plan.md &&
git add needs-plan.md done-plan.md status-loss-plan.md failed-plan.md prefix-plan.md last-record-plan.md reason-plan.md &&
git commit -q -m init
)

Expand Down Expand Up @@ -168,6 +169,8 @@ run_loop prefix "$REPO/prefix-plan.md" 'RESULT: DONEISH' 2
PREFIX_RC=$?
run_loop last-record "$REPO/last-record-plan.md" $'RESULT: FAILED\nearlier failure\nRESULT: DONE'
LAST_RECORD_RC=$?
run_loop reason "$REPO/reason-plan.md" 'RESULT: BLOCKED — active lock prevented the bounded tests'
REASON_RC=$?
run_failed_loop
run_status_loss

Expand Down Expand Up @@ -273,6 +276,15 @@ t7_result_records_are_full_line_and_last_wins() {
{ echo "last anchored DONE record did not win"; return 1; }
}

t7b_result_trailing_reason_is_blocked() {
local starts
[ "$REASON_RC" -eq 11 ] || { echo "trailing-reason rc=$REASON_RC want 11"; return 1; }
starts=$(grep -c '^task ' "$TEST_ROOT/reason.calls" || true)
[ "$starts" -eq 1 ] || { echo "trailing-reason starts=$starts want 1"; return 1; }
! grep -qx 'IMPLEMENTER_STATE: COMPANION_FAILURE' "$TEST_ROOT/reason.stderr" ||
{ echo "trailing-reason was classified as companion failure"; return 1; }
}

t8_failed_result_evidence_reaches_next_dispatch() {
local starts evidence samples first second
[ "$FAILED_LOOP_TIMED_OUT" -eq 0 ] || { echo "failed-evidence loop timed out"; return 1; }
Expand Down Expand Up @@ -911,6 +923,7 @@ check t4_second_stop_appended "second stop appends a second history block"
check t5_verified_done_unchanged "VERIFIED_DONE appends nothing"
check t6_status_loss_fails_closed "status loss blocks after one dispatch and retains poison"
check t7_result_records_are_full_line_and_last_wins "RESULT records are anchored and the last record wins"
check t7b_result_trailing_reason_is_blocked "RESULT trailing reason remains a real BLOCKED result"
check t8_failed_result_evidence_reaches_next_dispatch "FAILED result evidence reaches the next dispatch"
check t8b_stuck_attempt_history_persists "STUCK persists bounded attempt history in the plan"
check t8c_result_transport_failure_blocks_without_retry "result transport failure blocks without billing a retry"
Expand Down