ENH-296 Giving Tuesday, Metrics and Documentation

[grant-minor-sntialtech]

No description provided.

[grant-minor-sntialtech]

I believe to correct the prettier stuff I just run:
npm run lint:prettier

Correct?

[bickelj]

@grant-minor-sntialtech I don't want to get too pedantic about commit histories but I think we'll want to squash/rebase all the fixes into 1-3 commits before pushing. I asked GLM-5.2 for a review and it usually gives decent feedback.

[bickelj]

@grant-minor-sntialtech I think the enormous docs files might be too verbose to maintain. It looks like they were generated as summaries of what can be found in the code, and if they are useful I suppose they should stay. But perhaps they can be condensed to repeat less of what can be easily found when examining the code. I like the little tables showing which commands need PDC auth and which don't, though, that part is very handy.

[bickelj-agent]

Reviewed PR #297; npm run lint and the full Jest suite (68 tests) pass locally. Three follow-ups, posted inline: the pdc-bulk-uploader → pdc-metrics default change left the code comment and the docs inconsistent, and src/getMetrics-report.md is referenced but does not exist.

Minor, not commented inline

• All three new docs use repo-relative links that resolve wrong from docs/ (e.g. [src/index.ts](src/index.ts) → docs/src/index.ts); consider ../src/.... docs/getMetrics.md line 3 also drops the src/ prefix ([getMetrics.ts](getMetrics.ts)) while the other two docs keep it.
• classifyHttpError reports Unexpected HTTP status undefined for transport errors with no response; a distinct note for the no-response case would read more clearly.

— GLM-5.2

[grant-minor-sntialtech]

For the comment around:
classifyHttpError reports Unexpected HTTP status undefined for transport errors with no response; a distinct note for the no-response case would read more clearly.

I'm not an expert, but I don't believe there is a status for 'no response'. You still get a header and stuff... Is this to start tracking network timeouts?