Display Phantasm DPS in Total DPS - #4661
Conversation
| fullDPS.poisonDPS = fullDPS.poisonDPS + activeSkill.phantasm.minion.output.PoisonDPS * (activeSkill.phantasm.minion.output.TotalPoisonStacks or 1) * activeSkillCount | ||
| end | ||
| if activeSkill.phantasm.minion.output.ImpaleDPS and activeSkill.phantasm.minion.output.ImpaleDPS > 0 then | ||
| fullDPS.impaleDPS = fullDPS.impaleDPS + activeSkill.phantasm.minion.output.ImpaleDPS * activeSkillCount |
There was a problem hiding this comment.
Here activeSkillCount is the count of the source socket group, whereas the Phantasm cap calculated by this PR is stored in activeSkill.phantasm.count. In an asymmetric reproduction on this exact HEAD (source count 2, Phantasm count 5), this block contributes poison and impale using x2 rather than x5, so those components are not included at the maximum Phantasm limit promised by the PR. Using activeSkill.phantasm.count for both explicit accumulators produced the expected per-Phantasm totals in the focused reproduction.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.
|
|
||
| if activeSkill.phantasm then | ||
| if activeSkill.phantasm.minion.output.TotalDPS and activeSkill.phantasm.minion.output.TotalDPS > 0 then | ||
| t_insert(fullDPS.skills, { name = activeSkill.phantasm.name, dps = activeSkill.phantasm.minion.output.TotalDPS, count = activeSkill.phantasm.count, trigger = activeSkill.infoTrigger, skillPart = "Summoned by: "..activeSkill.phantasm.source }) |
There was a problem hiding this comment.
With Summon Phantasm supporting a player skill, addMinionList = { "SummonedPhantasm" } already makes the generic minion block above emit the selected Phantasm contribution. This added row then emits the same group again. The exact-HEAD fixture produced hit rows of 7 x 2 and 7 x 5 (plus the distinct source's 3 x 2), yielding 55 instead of the deduplicated 41. Skipping the generic row only when it represents that same selected SummonedPhantasm removed the duplicate while preserving a distinct source minion.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.
3 participants
Description of the problem being solved:
Phantasms are not being counted in the Total DPS even if the skill has this support gem inserted
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/HMjN6iKQ-EDg
Before screenshot:
After screenshot: