Skip to content

docs(rulesets): list required_deployments as an ignored ruleset rule - #12367

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564
Aug 13, 2026
Merged

docs(rulesets): list required_deployments as an ignored ruleset rule#12367
mergify[bot] merged 1 commit into
mainfrom
devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564

Conversation

@sileht

@sileht sileht commented Aug 12, 2026

Copy link
Copy Markdown
Member

The Ruleset Rule Compatibility table put "Used by Merge Protections" in the required_deployments behavior column, directly under two rows reading "Injected as conditions". Readers compare the rows and conclude Mergify turns the rule into a merge condition, i.e. that it holds a pull request until the required deployment succeeds. It does not. The confusion is not hypothetical: a HackerOne reporter built an authorization-bypass report on that reading.

get_repository_rulesets_conditions() branches on required_status_checks and pull_request only. There is no required_deployments branch, so the rule is never injected, for the merge action or the merge queue.

The table has nothing to say about a rule Mergify does not inject, so the row goes and required_deployments joins the Ignored Rule Types list, which already says what a reader needs: "Mergify will not enforce them", "ensure they are enforced by GitHub directly on your target branch".

The intro made the same blanket claim one level up ("injects them as conditions"), now "injects the supported ones".

One caveat for the reviewer: the Ignored Rule Types section opens with "not processed by Mergify". That is true of the injection pipeline, which is what this page covers, but Mergify does read the rule elsewhere, in the Merge Protections healthcheck for reporting_method: deployments. If you would rather that nuance were visible, it belongs on the Merge Protections page, not here.

Adjacent PR: #12362 rewrites the bypass-mode guidance on this same file. It does not touch the table or the ignored list, and the two merge cleanly.

Fixes MRGFY-8644

Copilot AI lite review requested due to automatic review settings August 12, 2026 17:55
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 12, 2026 17:55 Failure
@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • all of:
      • author = mergify-ci-bot
      • -head ~= ^docs-agent/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the GitHub Rulesets compatibility documentation so readers don’t misinterpret required_deployments as a Mergify-injected merge condition, and instead understand that GitHub enforces it while Mergify only reads it for a specific Merge Protections configuration check.

Changes:

  • Updates the required_deployments compatibility-table row to explicitly state it is not injected and is enforced by GitHub.
  • Adds a new “Required Deployments” section explaining enforcement behavior and the one case where Mergify reads the rule.
  • Tightens surrounding explanatory text to clarify that only “Injected as conditions” rows become Mergify conditions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/content/docs/merge-queue/github-rulesets.mdx Outdated
@mergify
mergify Bot requested a review from a team August 12, 2026 17:58
@sileht
sileht marked this pull request as ready for review August 12, 2026 17:58
@sileht

sileht commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial deb4a2f 2026-08-12 18:01 UTC
2 content deb4a2f → 6e32f13 2026-08-12 18:01 UTC
3 content 6e32f13 → a5d30cf 2026-08-12 18:15 UTC
4 content a5d30cf → 34020e1 2026-08-12 18:24 UTC

@sileht
sileht force-pushed the devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564 branch from deb4a2f to 6e32f13 Compare August 12, 2026 18:01
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 12, 2026 18:02 Failure
@sileht
sileht marked this pull request as draft August 12, 2026 18:06
@sileht
sileht force-pushed the devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564 branch from 6e32f13 to a5d30cf Compare August 12, 2026 18:15
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections August 12, 2026 18:15 Failure
The Ruleset Rule Compatibility table put "Used by Merge Protections" in the
`required_deployments` behavior column, directly under two rows reading
"Injected as conditions". Readers compared the rows and concluded Mergify
turns the rule into a merge condition and holds a pull request until the
required deployment succeeds. It does not: the rule is never injected, for
the merge action or the merge queue.

There is nothing for the table to say about it, so the row goes and the rule
joins the Ignored Rule Types list, which already carries the right message:
Mergify will not enforce these, ensure GitHub does.

The intro made the same blanket claim one level up and now says Mergify
injects the supported rules as conditions.

Fixes MRGFY-8644

Change-Id: Id4da85649474e01415e299033832bf04154a172b
@sileht sileht changed the title docs(rulesets): say GitHub, not Mergify, enforces required_deployments docs(rulesets): list required_deployments as an ignored ruleset rule Aug 12, 2026
@sileht
sileht force-pushed the devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564 branch from a5d30cf to 34020e1 Compare August 12, 2026 18:24
@mergify
mergify Bot deployed to Mergify Merge Protections August 12, 2026 18:24 Active
@sileht
sileht marked this pull request as ready for review August 12, 2026 18:33
@mergify
mergify Bot requested a review from a team August 13, 2026 06:45
@mergify

mergify Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 3 minutes 28 seconds in the queue, including 2 minutes 27 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Aug 13, 2026
@mergify
mergify Bot merged commit f55d23a into main Aug 13, 2026
10 checks passed
@mergify
mergify Bot deleted the devs/sileht/mrgfy-8644-clarify-required-deployments-row/say-github-mergify-enforces-required-deployments--d4da8564 branch August 13, 2026 07:07
@mergify mergify Bot removed the queued label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants