Tighten birth and arrival entry and move lookup admin to one page - #28
Merged
labkey-martyp merged 3 commits intoAug 27, 2026
Merged
Conversation
The birth and arrival forms carried separate protocol, project and group assignment sections, so an animal could be entered with none of them. Those sections are gone: the three assignments are now required fields on the animal's own row, and the trigger scripts open the matching records. The conception on a birth row can now be changed by clicking its cell, and a conception may only ever have one birth, including across rows entered together, which the previous check could not see. The housing location hierarchy and the investigator, project and protocol lists are now maintained through Manage Lookup Tables instead of their own data entry forms, and buildings, floors and cages gain a disable date so the whole hierarchy can be retired rather than only deleted. Retired values drop out of the pickers but still show where they were already recorded. Also corrects two species entries and loads the source facility list.
The cage pickers now label a cage by its derived location rather than its name, so the birth and arrival tests enter and expect the full location. Live validation sends only the row that just changed, so a rule comparing the rows of one form entry can report only by refusing the save; the duplicate conception test now asserts that refusal at submit rather than during entry.
labkey-bpatel
approved these changes
Aug 27, 2026
A refused save leaves the browser on the form, so the confirmation click cannot wait for a page load, and the refusal is logged as a server error that the run's error check would otherwise fail the test over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Make the birth and arrival forms record a complete animal, and give the housing hierarchy and the assignment lists one place to be maintained. An animal could be entered with no protocol, project or group assignment, because each of those lived in a separate section of the form that was easy to leave empty, and two births could claim the same conception when they were entered together. Separately, the housing location tables and the investigator, project and protocol lists each carried their own data entry form, and most of the hierarchy could only be deleted rather than retired.
Related Pull Requests
None.
Changes
Enter an animal's opening protocol, project and group assignment on its birth or arrival row, where each is required, rather than in separate sections that could be left empty.
Pick the conception a birth came from by clicking it on the row, and refuse a second birth against a conception that already has one, including a birth entered on the same form.
Maintain the housing location hierarchy and the investigator, project and protocol lists through Manage Lookup Tables instead of a data entry form for each, and allow buildings, floors and cages to be retired rather than only deleted.
Drop the ways of adding a row that the birth and conception forms should not offer, and show the protocol rather than its display name on the animal snapshot.
Correct two species entries and load the source facility list.