GitHub Issue #696: Make Applying Filters to Custom Grid View More Apparent - #2068
GitHub Issue #696: Make Applying Filters to Custom Grid View More Apparent#2068cnathe wants to merge 12 commits into
Conversation
…essage area display), read only display
…stead of just title attr
…ader and save view modal
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good. I pushed a small set of changes to get the tests to pass type checks.
| </div> | ||
| ); | ||
|
|
||
| if (!!isReadOnly) { |
There was a problem hiding this comment.
nit: (Unrelated) Interesting that isReadOnly is of type string. Seems like it should have been renamed when it was reappropriated to carry a message.
There was a problem hiding this comment.
agreed. I was confused by this as well until I realized it was the read-only hover message. I'm going to leave it for this PR
| import { ChartList } from './ChartPanel'; | ||
|
|
||
| const READONLY_FILTER_TIP = | ||
| "Filter can't be edited because it's saved with the view. Remove it and add it again to make changes."; |
There was a problem hiding this comment.
nit: Consider not using contractions. Something like:
Filter cannot be edited as it is saved with the view. Remove it and add it again to make changes.
There was a problem hiding this comment.
That works for me. I was just going off of the mockup from Keegan.
2 participants
Rationale
https://github.com/LabKey/internal-issues/issues/696
App grid filter updates to makes it obvious that saving a grid view includes the current set of filters and sorts. Read-only (saved-with-view) filter pills in the grid message bar are greyed and get a hover popover explaining why they can't be edited. The Save Grid View modal replaces the easy-to-miss "Columns, sort order, and filters will be saved" sentence with two labelled sections listing the actual filter and sort pills that will be persisted, with empty-state messages when there are none.
Related Pull Requests
Changes