Skip to content

Adding Leetcode and /eightball responses - #487

Merged
must108 merged 1 commit into
KnightHacks:mainfrom
mbti0n:main
Aug 14, 2026
Merged

Adding Leetcode and /eightball responses#487
must108 merged 1 commit into
KnightHacks:mainfrom
mbti0n:main

Conversation

@mbti0n

@mbti0n mbti0n commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why

Adding new prompts to TK's daily Leetcode reminders and /eightball responses.

What

Added new prompts inside the 2 arrays DAILY_MESSAGES (5 new prompts) and EIGHTBALL_RESPONSES (11 new responses) of forge/apps/tk/src/consts/index.ts.

Test Plan

Since the prompts of daily Leetcode reminders and /eightball responses are randomized (and I failed to set up the appropriate environment to start TK on my end), I want to have the bot tested in the Knight Hacks Discord server.

Checklist

  • No schema changes.
  • No environment variables changed.

Summary by CodeRabbit

  • New Features
    • Expanded the eight-ball experience with 17 additional responses.
    • Added a broader mix of affirmative, uncertain, negative, boolean-style, and informal answers.
    • Responses now offer more variety when asking questions, including concise and playful options.
    • Added seven new messages to the LeetCode daily message rotation.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The pull request adds seventeen responses to EIGHTBALL_RESPONSES and seven messages to the LeetCode cron's DAILY_MESSAGES rotation.

Changes

Message Pool Updates

Layer / File(s) Summary
Eightball response strings
apps/tk/src/consts/index.ts
Seventeen informal, affirmative, uncertain, negative, boolean-like, and short response strings are appended to EIGHTBALL_RESPONSES.
LeetCode daily message rotation
apps/cron/src/crons/leetcode.ts
Seven new entries are added to the daily LeetCode message pool.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: CRON, T.K, Feature

Suggested reviewers: dvidal1205

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the response changes but does not start with the required issue number format such as "[#123]". Add the issue number in brackets at the start, followed by a concise description, for example "[#123] Add LeetCode and /eightball responses".
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hardcoded Secrets ✅ Passed The pull-request diff adds only LeetCode and Eight Ball message strings; scans found no API-key, password, token, secret, bearer, or credential-shaped literals.
Validated Env Access ✅ Passed The parent-to-HEAD diff adds only string literals in two arrays; no added or existing process.env usage appears in either changed file.
No Typescript Escape Hatches ✅ Passed The PR adds only string literals to two arrays; the added TypeScript lines contain no any, @ts-ignore, @ts-expect-error, or non-null assertions (!.).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously requested changes Jul 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/tk/src/consts/index.ts`:
- Around line 19-23: The LeetCode reminder is still using a separate
DAILY_MESSAGES list instead of the shared constants, so the new strings in the
shared export are never picked up. Update the LeetCode cron logic in leetcode.ts
to import and use the shared daily-message export from consts/index.ts, and
remove the duplicate DAILY_MESSAGES definition so there is a single source of
truth.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: efb1a21b-782b-4920-b378-3de2e1152f32

📥 Commits

Reviewing files that changed from the base of the PR and between e43730e and 2d0602e.

📒 Files selected for processing (1)
  • apps/tk/src/consts/index.ts

Comment thread apps/tk/src/consts/index.ts Outdated

@DVidal1205 DVidal1205 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lol

@mbti0n
mbti0n requested a review from DVidal1205 July 8, 2026 02:59
@DVidal1205
DVidal1205 requested a review from a team as a code owner August 8, 2026 00:03
alexanderpaolini pushed a commit to mbti0n/forge that referenced this pull request Aug 12, 2026
Preserve the live portion of PR KnightHacks#487 after main removed the unused LeetCode reminder path.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/tk/src/consts/index.ts`:
- Line 119: In the response text constant containing "That seems potential.",
replace the wording with "That seems possible." while leaving the surrounding
constants and behavior unchanged.
- Line 126: Replace the abusive “Lame question, sybau 💔” entry in the random
response constants with neutral, user-friendly wording while preserving the
existing response collection and eight-ball behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e26bc44-0119-4667-90de-3ac357a39db5

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4205e and 88c9c78.

📒 Files selected for processing (1)
  • apps/tk/src/consts/index.ts

Comment thread apps/tk/src/consts/index.ts
Comment thread apps/tk/src/consts/index.ts
alexanderpaolini pushed a commit to mbti0n/forge that referenced this pull request Aug 12, 2026
Rebase PR KnightHacks#487 onto current main and place the LeetCode prompts in the live cron-owned message list.
alexanderpaolini pushed a commit to mbti0n/forge that referenced this pull request Aug 12, 2026
Rebase PR KnightHacks#487 onto current main and place the LeetCode prompts in the live cron-owned message list.
coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 12, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/cron/src/crons/leetcode.ts`:
- Around line 37-43: Keep this PR scoped to the cron application by removing the
unrelated changes under the TK application, including updates to its constants.
Only retain TK modifications if a demonstrated dependency is required by the
cron implementation; otherwise move them to a separate PR.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 437acfa7-723d-43ed-a56a-2e10db97e9c2

📥 Commits

Reviewing files that changed from the base of the PR and between 88c9c78 and 95b3ed3.

📒 Files selected for processing (1)
  • apps/cron/src/crons/leetcode.ts

Comment thread apps/cron/src/crons/leetcode.ts
Rebase PR KnightHacks#487 onto current main and place the LeetCode prompts in the live cron-owned message list.
@must108
must108 added this pull request to the merge queue Aug 14, 2026
Merged via the queue into KnightHacks:main with commit dfac35c Aug 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants