Show frame metadata in Dataset Info - #1809
Open
PaulHax wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of a four-PR stack, on top of #1808. Review only this PR's own commits; the base branch carries
#1806, #1807, and #1808.
Summary
A read-only Frame Metadata panel synchronized to the active camera and playhead.
This slice includes the Dataset Info refactor so behavior and presentation review together: Dataset
Info splits into focused Frame Metadata, Dataset Info, and Custom Dataset Info panels, preserving
custom-field editing. The frame panel names the attachment source and distinguishes loading and
delayed video readiness; no attachment; no row for this frame; invalid readable CSV/TXT; a valid but
unmatched table; opaque JSON still available to pipelines; an unavailable attachment; and
unsupported media types that keep the attachment for pipelines but resolve no rows.
User documentation covers attachment placement, accepted formats, image join precedence, the literal
video frame contract, camera-local precedence, pipeline reuse, and current limits.
Behavior change beyond frame metadata: the context sidebar now opens on Dataset Info instead of
Threshold Controls, for every dataset and user.
Reviewer focus
Manual test
Upload each directory, open Dataset Info, and expand Frame Metadata. These nine cover every
state the panel distinguishes, on both image sequences and video. The set is CC0 NOAA Okeanos
Explorer media with synthetic metadata, attached to #1806 as
okeanos-frame-metadata-fixtures.zip. Select all files in one directory per test.okeanos-frame-metadata-fixtures.zip
Seven directories carry a reserved
frame-metadata.*/frame_metadata.*name and arediscovered automatically, spread across five of the six spellings —
.txtproves the extensiondoes not drive parsing.
okeanos-image-explicit-framecarries an ordinary name and must bepicked into the Metadata File slot by hand; that is the path with no reserved-name safety net,
so a regression there is silent.
okeanos-upload-authority-ignorenotes.txt, ignored at upload — never an attachmentokeanos-frame-metadata-uploadframe-metadata.csv, besideannotations.csvSource: frame-metadata.csv. The two imported tracks (fish 0-12, vehicle 13-15) come from the VIAME CSV — the attachment contributes none.okeanos-image-explicit-frameex1402-dive11-telemetry.csv(picked, not discovered)okeanos-image-counter-matchframe_metadata.txtframe_count=1, frame 15 showsframe_count=16. The wide source-column order is preserved, and the unrelated 900/901 rows never appear.okeanos-frame-metadata-nonmatchingframe-metadata.txtokeanos-image-invalidframe_metadata.csv— header, no data rowsokeanos-video-explicit-frameframe-metadata.csvframe; every neighbouring frame shows "No frame metadata for the current frame."okeanos-video-filename-unmatchedframe-metadata.csv— byte-identical to the one above that joins by filenameokeanos-video-opaque-jsonframe_metadata.jsonAlso verify: scrubbing between populated and unpopulated frames updates immediately without another
source download; returning to a populated frame restores the same ordered values; Dataset Info and
Custom Dataset Info still show and edit their prior fields; and in
okeanos-frame-metadata-uploadthe two imported tracks come from the VIAME CSV alone — the metadata attachment created none.