[WIP] [Performance] Pre-mount new expense destinations behind confirmation RHP - #97874
[WIP] [Performance] Pre-mount new expense destinations behind confirmation RHP#97874JakubKorytko wants to merge 5 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 946460a7b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
d77efce to
c5ccc51
Compare
Explanation of Change
Improves confirmation RHP destination pre-mounting for new 1:1 chats and employer workspaces. It reuses stable optimistic report IDs, safely promotes draft reports for rendering, suppresses premature report fetching, cleans interrupted promotions, and disables native RHP swipe-back while a pre-insert is active to prevent flashes or stuck loading states.
Fixed Issues
$ TBA
PROPOSAL: N/A
Tests
+, selectCreate expense, enter an amount, and choose that user as the recipient.Create expense.SUBMIT_2026beta enabled and no existing workspace, open a tracked expense in the self chat, and clickSubmit to my employer.Create expenseon the confirmation page.Offline tests
Create expense.QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari