feat: Add option to override toolchain on a per target basis - #294
Merged
Conversation
furtib
changed the title
furtib
force-pushed
the
per-target-toolchain-selection
branch
from
August 17, 2026 11:28
49eeec8 to
8c383e1
Compare
nettle
reviewed
Aug 17, 2026
furtib
commented
Aug 18, 2026
furtib
left a comment
furtib
left a comment
Contributor
Author
There was a problem hiding this comment.
Thank you for the review!
furtib
force-pushed
the
per-target-toolchain-selection
branch
from
August 19, 2026 07:18
f4a947e to
0c119c9
Compare
Szelethus
reviewed
Aug 24, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
LGTM from the code's perspective -- should we not bother with a skylib test?
Contributor
Author
|
see #301 for tests |
furtib
force-pushed
the
per-target-toolchain-selection
branch
from
August 24, 2026 12:06
0c119c9 to
dd9d8c3
Compare
furtib
force-pushed
the
per-target-toolchain-selection
branch
from
August 24, 2026 12:07
dd9d8c3 to
715d99c
Compare
furtib
changed the title
furtib
changed the title
furtib
changed the title
furtib
changed the title
furtib
changed the title
Szelethus
approved these changes
Aug 25, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
LGTM on my end. These skylib tests are quite neat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Users want the ability to use different versions of CodeChecker (or analyzers) on a per-target basis.
What:
codechecker_toolchainparameter tocodechecker_test, through which users can override Bazel's toolchain resolution. (Preserves previous behaviour if not specified.)Addresses:
Fixes: #278