Use Great Spectations - #9366
Open
rustyrussell wants to merge 5 commits into
Open
Conversation
This is already used as a marker, so make it universal. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
These are now in the main tree. The only one which isn't is the comment on reserve, which does not appear anywhere. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. max_dust_htlc_exposure_msat was merged: lightning/bolts#919 2. sciddir_or_pubkey was merged: lightning/bolts#798 3. gossip node check was merged: lightning/bolts#1333 4. gossip features obsolescence was merged: lightning/bolts#1092 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Great Spectations is stricter, and spotted these errors: both missing colons, and some things which might be mistaken for bolt quotes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…cker. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Collaborator
|
This looks good. |
Lagrang3
reviewed
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've generalized CLN's custom quote checking into a generic Python tool, and applied it here (see https://greatspectations.org).
It's a bit stricter with BOLT quotes, so it caught some malformed ones: I fixed those up first.