Makefile: call cargo for binary targets if workspace library dependencies changed - #9358
Open
daywalker90 wants to merge 1 commit into
Open
Makefile: call cargo for binary targets if workspace library dependencies changed#9358daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
daywalker90
added
the
Status::Ready for Review
Andezion
reviewed
Jul 29, 2026
| $(RUST_TARGET_DIR)/examples/cln-subscribe-wildcard: ${CLN_RPC_SOURCES} ${CLN_PLUGIN_SRC} plugins/examples/cln-subscribe-wildcard.rs | ||
| $(CARGO) build ${CARGO_OPTS} --example cln-subscribe-wildcard | ||
|
|
||
| $(RUST_TARGET_DIR)/cln-grpc: ${CLN_PLUGIN_SRC} ${CLN_GRPC_PLUGIN_SRC} $(MSGGEN_GENALL) $(MSGGEN_GEN_ALL) |
Collaborator
There was a problem hiding this comment.
Was cln-grpc left out on purpose,do you think $(MSGGEN_GENALL) already covers it well enough in practice? As i understood $(MSGGEN_GENALL) already pulls in cln-rpcs generated files like model.rs, notifications.rs, hooks.rs, but not the rest of cln-rpcs hand-written sources like cln-rpc/src/lib.rs. plugins/grpc-plugin/src/main.rs does use cln_rpc::notifications::Notification so maybe we need $(RUST_TARGET_DIR)/cln-grpc: ${CLN_PLUGIN_SRC} ${CLN_GRPC_PLUGIN_SRC} $(MSGGEN_GENALL) $(MSGGEN_GEN_ALL)?
Collaborator
Author
There was a problem hiding this comment.
In practice cln-grpc was rebuilding in most cases, but you are right it needs ${CLN_RPC_SOURCES} as well. Fixed.
…cies changed Changelog-None
daywalker90
force-pushed
the
makefile-fix-dep-invoke
branch
from
July 29, 2026 09:54
bdceb59 to
7d8f0c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.