-
Notifications
You must be signed in to change notification settings - Fork 28
Start improving high-throughput multi-camera recording path and diagnostics #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
C-Achard
merged 20 commits into
cy/preserve-mono-support
from
cy/improve-encoding-speed
Aug 20, 2026
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
827ec1b
Use one-by-one Basler grab strategy
C-Achard 3ba4546
Ignore profiling output artifacts
C-Achard 29fcfeb
Add profiling extra with Scalene
C-Achard dd4e863
Optimize recording pipeline and encoder options
C-Achard 0516496
Enable timing logs and enrich recorder stats
C-Achard 8cf3ae8
Expand recording behavior test coverage
C-Achard b5eed13
Persist fast encoding setting in GUI
C-Achard d671625
Always wire recording setting signal handlers
C-Achard 7efe8f9
Disable default timing logs and fix stats import
C-Achard c1d2202
Fix writer defaults and buffer time fallback
C-Achard 19fbcac
Defer recording until preview frames are ready
C-Achard b978818
Disable delayed auto-start of recording
C-Achard b610d68
Update main_window.py
C-Achard e609b6a
Centralize trigger debug logging flag
C-Achard 6e3a7cd
Normalize WriteGear options and rename overrides
C-Achard 59ed076
Align tests with writer options override rename
C-Achard cbbe14f
Fix merge conflict
C-Achard 9c32b26
Guard recording start when no cameras configured
C-Achard b9feabd
Update tests for writegear option builder
C-Achard 9bcd61b
Add Basler acquisition stats debug logging
C-Achard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a big unconditional change which we should give some consideration.
I understand that we want to prevent discarding intermediate frames (which is mostly useful for viewing, but not recording), but processing all frames in arrival order also has it's risks/downsides. Some remarks/questions:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok after discussing in real life: we don't know what the buffer exactly looks like, but as they recommend it in production (see https://docs.baslerweb.com/pylonapi/pylon-sdk-samples-manual) we can assume it is the safest way to process and we can probably assume a FIFO principle.
Still, might be good to have diagnostics in case they are available. Then we can always see empirically in practice.