Skip to content

[Infrastructure,Common] Fix precompiled header creation #17521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Aug 20, 2026
+16 −2
Merged

[Infrastructure,Common] Fix precompiled header creation #17521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Common/Core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ o2physics_add_library(AnalysisCore
# Skipped under recc, which caches compilations remotely instead -- the two do
# not combine, as a PCH is a local artefact of one compiler invocation.
#
# The link libraries have to match what the reusing targets compile with, so
# this carries only what every workflow already links.
# The reusing targets must compile with the same preprocessor state as this
# carrier, which does not follow from the link list: AnalysisCore reaches
# O2::rANS and its INTERFACE -DRANS_ENABLE_JSON, whereas a bare workflow links
# only O2::Framework. o2physics_add_dpl_workflow therefore copies this target's
# compile definitions onto every consumer; keep that in mind when changing what
# is linked here.
add_library(AnalysisPCH OBJECT analysisPCH.cxx)
target_link_libraries(AnalysisPCH PUBLIC O2::Framework O2Physics::AnalysisCore)
if(NOT DEFINED ENV{USE_RECC})
Expand Down
10 changes: 10 additions & 0 deletions cmake/O2PhysicsAddWorkflow.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ function(o2physics_add_dpl_workflow baseTargetName)
# A target cannot reuse its own PCH, and the carrier is not built when recc
# is caching compilations remotely instead.
if(_pch AND NOT _pch STREQUAL targetExeName AND NOT DEFINED ENV{USE_RECC})
# GCC refuses a PCH built with a different preprocessor state than the
# consumer's, and -Werror turns that refusal into a build failure:
# cmake_pch.hxx.gch: not used because `RANS_ENABLE_JSON' not defined
# The carrier links O2Physics::AnalysisCore, which reaches O2::rANS and its
# INTERFACE -DRANS_ENABLE_JSON, while a workflow that links only
# O2::Framework (the converters, the tutorials) never sees it. Hand every
# consumer the carrier's definitions so the two agree. Definitions only --
# this must not add link dependencies to targets that do not want them.
target_compile_definitions(${targetExeName} PRIVATE
$<TARGET_PROPERTY:${_pch},COMPILE_DEFINITIONS>)
target_precompile_headers(${targetExeName} REUSE_FROM ${_pch})
endif()

Expand Down
Loading