[PWGCF] Updated for efficiency correction by pravatp98 · Pull Request #17462 · AliceO2Group/O2Physics

pravatp98 · 2026-08-14T14:03:39Z

Updated for efficiency correction and sub-sampling

github-actions · 2026-08-14T14:03:56Z

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

alibuild · 2026-08-14T17:14:01Z

Error while checking build/O2Physics/code-check for d0814e2 at 2026-08-14 19:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/ffbf5b7845c9b8727bf3d50aed3e98830ccf3f29/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild · 2026-08-14T19:15:35Z

Error while checking build/O2Physics/staging for 0f85e5a at 2026-08-14 21:15:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-14T21:34:12Z

Error while checking build/O2Physics/code-check for 0f85e5a at 2026-08-15 00:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/cb48a4d8a16dbc4f423cd20c183286a55a5a5ec8/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild · 2026-08-15T05:39:57Z

Error while checking build/O2Physics/staging for 3a07d25 at 2026-08-15 07:39:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-15T07:26:10Z

Error while checking build/O2Physics/staging for 9163cf3 at 2026-08-15 09:26:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-15T08:54:29Z

Error while checking build/O2Physics/code-check for 9163cf3 at 2026-08-15 15:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/62cdae37fa6a31c9a3586efa4827badc3f6ae80e/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

alibuild · 2026-08-16T10:49:00Z

Error while checking build/O2Physics/code-check for ee7348d at 2026-08-16 12:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/f9d7ced54cad030da3475df29b402a58952a0402/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

pravatp98 · 2026-08-16T12:01:56Z

Dear @victor-gonzalez @SwatiSaha-1997
I have updated the code for efficiency correction and it have passes all the checks. Kindly please review and approve the PR

alibuild · 2026-08-16T16:59:22Z

Error while checking build/O2Physics/code-check for 3e2c34f at 2026-08-16 23:25:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 45 errors and 72 warnings.'
Found 45 errors and 72 warnings.
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/431f52f81e43417a365c2f8649abe0bf2071bc8e/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:26:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:40:1: error: included header TProfile.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:41:1: error: included header TProfile2D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:44:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:59:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:60:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:61:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:62:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:63:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:65:9: error: macro 'MC_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:66:9: error: macro 'MC_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:67:9: error: macro 'MC_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:68:9: error: macro 'MC_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:69:9: error: macro 'MC_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:103:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:117:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:131:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:139:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:149:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:154:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:565:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:568:17: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:572:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:819:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:866:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:880:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1067:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1068:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1104:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1124:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1175:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1176:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1560:15: error: variable 'idMethod' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1983:49: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1984:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1985:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1986:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1987:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1988:52: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1989:50: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

…ficiency correction Refactor identification bits to use constexpr instead of #define, update includes to comment out unused headers, and improve readability of various functions.

Commented out unused identification bits for clarity.

alibuild · 2026-08-17T12:07:18Z

Error while checking build/O2Physics/code-check for 5ceacf7 at 2026-08-17 14:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 9 errors and 3 warnings.'
Found 9 errors and 3 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/7002cc34a2e510adeb560b4887c784fcf2ce11e7/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:28:1: error: included header AnalysisHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:34:1: error: included header O2DatabasePDGPlugin.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1129:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1149:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1202:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:2312:39: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:2312:47: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/7002cc34a2e510adeb560b4887c784fcf2ce11e7/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1125:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1398:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:2066:41: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 9 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-08-18T01:04:37Z

Error while checking build/O2Physics/code-check for 2917414 at 2026-08-18 03:04:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-18T02:51:49Z

Error while checking build/O2Physics/code-check for d941851 at 2026-08-18 06:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/e855e9028f93e9fa8d6af153e7d639a0eb4d1a8f/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:72:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1130:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1150:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:1203:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

Updated for efficiency correction

82628a3

Updated for efficiency correction and sub-sampling

pravatp98 requested review from SwatiSaha-1997, alibuild, dsarkaralice, isputows, lauraser and victor-gonzalez as code owners August 14, 2026 14:03

github-actions Bot added the pwgcf label Aug 14, 2026

github-actions Bot changed the title ~~Updated for efficiency correction~~ [PWGCF] Updated for efficiency correction Aug 14, 2026

alibuild mentioned this pull request Aug 14, 2026

Please consider the following formatting changes to #17462 pravatp98/O2Physics#5

Closed

pravatp98 added 2 commits August 14, 2026 22:18

Refactor registry parameter to hReg in functions

d0814e2

Refactor track analysis to use hReg for histograms

0f85e5a

pravatp98 added 2 commits August 15, 2026 08:19

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

3a07d25

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

9163cf3

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

ee7348d

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

3e2c34f

pravatp98 added 4 commits August 17, 2026 16:38

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

1eeed0a

Refactor identification bits and clean up includes and updated for Ef…

ef11977

…ficiency correction Refactor identification bits to use constexpr instead of #define, update includes to comment out unused headers, and improve readability of various functions.

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

ebb1d2a

Comment out unused IdBitEL and IdBitDE

5ceacf7

Commented out unused identification bits for clarity.

Refactor conditional statements and parameter types

2917414

Merge branch 'AliceO2Group:master' into NetChargeFluctuations3

d941851

Navigation Menu

Uh oh!

[PWGCF] Updated for efficiency correction - #17462

[PWGCF] Updated for efficiency correction#17462
pravatp98 wants to merge 13 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

pravatp98 commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026 •

edited

Loading

Uh oh!

alibuild commented Aug 15, 2026

Uh oh!

alibuild commented Aug 15, 2026

Uh oh!

alibuild commented Aug 15, 2026 •

edited

Loading

Uh oh!

alibuild commented Aug 16, 2026

Uh oh!

pravatp98 commented Aug 16, 2026

Uh oh!

alibuild commented Aug 16, 2026 •

edited

Loading

Uh oh!

alibuild commented Aug 17, 2026

Uh oh!

alibuild commented Aug 18, 2026

Uh oh!

alibuild commented Aug 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pravatp98 commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

alibuild commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Aug 15, 2026

Uh oh!

alibuild commented Aug 15, 2026

Uh oh!

alibuild commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Aug 16, 2026

Uh oh!

pravatp98 commented Aug 16, 2026

Uh oh!

alibuild commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Aug 17, 2026

Uh oh!

alibuild commented Aug 18, 2026

Uh oh!

alibuild commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

alibuild commented Aug 14, 2026 •

edited

Loading

alibuild commented Aug 15, 2026 •

edited

Loading

alibuild commented Aug 16, 2026 •

edited

Loading

alibuild commented Aug 18, 2026 •

edited

Loading