Skip to content

[Common] Add option to override centrality calibration in centralityQa - #17404

Merged
ddobrigk merged 3 commits into
AliceO2Group:masterfrom
jesgum:centQa
Aug 12, 2026
Merged

[Common] Add option to override centrality calibration in centralityQa#17404
ddobrigk merged 3 commits into
AliceO2Group:masterfrom
jesgum:centQa

Conversation

@jesgum

@jesgum jesgum commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

To make it more convenient to quality check new centrality calibrations before uploading them centrally

tagging @romainschotter and @ddobrigk

@github-actions github-actions Bot changed the title Add option to override centrality calibration in centralityQa [Common] Add option to override centrality calibration in centralityQa Aug 11, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 2 errors, ⚠️ 21 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#17404
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f63e6bf at 2026-08-11 12:15:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/540a58be9a772dc710a7f4c09d283210de7869e3/O2Physics-code-check/errors.txt
Common/Tasks/centralityQa.cxx:42:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:145:16: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:159:14: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:268:71: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:491:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@ddobrigk
ddobrigk merged commit cafeb24 into AliceO2Group:master Aug 12, 2026
12 of 14 checks passed
@jesgum
jesgum deleted the centQa branch August 12, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants