Fix MegaLinter

Author: mhemmer-cern

PWGEM/PhotonMeson/Core/PairCut.h

@@ -33,8 +33,8 @@ class PairCut
     kNCuts
   };
 
-  [[nodiscard]] std::string getName() const { return name; }
-  [[nodiscard]] std::string getTitle() const { return title; }
+  [[nodiscard]] const std::string& getName() const { return name; }
+  [[nodiscard]] const std::string& getTitle() const { return title; }
 
   static const std::array<std::string, static_cast<std::size_t>(PairCuts::kNCuts)> mCutNames;
 

PWGEM/PhotonMeson/Tasks/HeavyNeutralMeson.cxx

@@ -148,9 +148,9 @@ struct HeavyNeutralMeson {
   HistogramRegistry mHistManager{"HeavyNeutralMesonHistograms", {}, OutputObjHandlingPolicy::AnalysisObject};
 
   // Prepare vectors for different species
-  std::vector<hnmutilities::GammaGammaPair> vGGs;
-  std::vector<hnmutilities::HeavyNeutralMeson> vHNMs;
-  std::vector<ROOT::Math::PtEtaPhiMVector> etaPrimeEMC, etaPrimePCM, omegaEMC, omegaPCM, proton, antiproton, deuteron, antideuteron, pion, antipion;
+  std::vector<hnmutilities::GammaGammaPair> mvGGs;
+  std::vector<hnmutilities::HeavyNeutralMeson> mvHNMs;
+  std::vector<ROOT::Math::PtEtaPhiMVector> etaPrimeEMC, etaPrimePCM, omegaEMC, omegaPCM, pion, antipion;
   float mMassProton = constants::physics::MassProton;
   float mMassDeuteron = constants::physics::MassDeuteron;
   float mMassOmega = 0.782;
@@ -371,7 +371,7 @@ struct HeavyNeutralMeson {
     // clean vecs
     pion.clear();
     antipion.clear();
-    vHNMs.clear();
+    mvHNMs.clear();
     // vGGs vector is cleared in reconstructGGs.
 
     // ---------------------------------> EMCal event QA <----------------------------------
@@ -408,9 +408,9 @@ struct HeavyNeutralMeson {
 
     std::vector<hnmutilities::Photon> vGammas;
     hnmutilities::storeGammasInVector(clustersInThisCollision, v0sInThisCollision, vGammas, emcEtaShift, emcPhiShift);
-    hnmutilities::reconstructGGs(vGammas, vGGs);
+    hnmutilities::reconstructGGs(vGammas, mvGGs);
     vGammas.clear();
-    processGGs(vGGs);
+    processGGs(mvGGs);
 
     // ------------------------------> Loop over all tracks <-------------------------------
     // - Sort them into vectors based on PID ((anti)protons, (anti)deuterons, (anti)pions)
@@ -502,7 +502,7 @@ struct HeavyNeutralMeson {
     for (const auto& posPion : pion) {
       for (const auto& negPion : antipion) {
         ROOT::Math::PtEtaPhiMVector vecPiPlPiMi = posPion + negPion;
-        hnmutilities::reconstructHeavyNeutralMesons(vecPiPlPiMi, vGGs, vHNMs);
+        hnmutilities::reconstructHeavyNeutralMesons(vecPiPlPiMi, mvGGs, mvHNMs);
 
         mHistManager.fill(HIST("HNM/Before/PiPlPiMi/fInvMassVsPt"), vecPiPlPiMi.M(), vecPiPlPiMi.pt());
         mHistManager.fill(HIST("HNM/Before/PiPlPiMi/fEta"), vecPiPlPiMi.eta());
@@ -523,7 +523,7 @@ struct HeavyNeutralMeson {
     // ---------------------------> Process HNM candidates <--------------------------------
     // - Fill invMassVsPt histograms separated into HNM types (based on GG mass) and gamma reco method
     // -------------------------------------------------------------------------------------
-    processHNMs(vHNMs);
+    processHNMs(mvHNMs);
   }
 
   /// \brief Loop over the GG candidates, fill the mass/pt histograms and set the isPi0/isEta flags based on the reconstructed mass

PWGEM/PhotonMeson/Tasks/SinglePhoton.cxx

@@ -152,7 +152,7 @@ struct SinglePhoton {
     o2::aod::pwgem::photon::histogram::AddHistClass(fMainList, "Photon");
     auto* list_photon = dynamic_cast<THashList*>(fMainList->FindObject("Photon"));
 
-    for (auto& detname : fDetNames) {
+    for (const auto& detname : fDetNames) {
       LOGF(info, "Enabled detector = %s", detname.data());
 
       o2::aod::pwgem::photon::histogram::AddHistClass(list_ev, detname.data());

PWGEM/PhotonMeson/Tasks/SinglePhotonMC.cxx

@@ -88,8 +88,8 @@ struct SinglePhotonMC {
   THashList* fMainList = new THashList();
 
   std::vector<V0PhotonCut> fPCMCuts;
-  std::vector<PHOSPhotonCut> fPHOSCuts;
-  std::vector<EMCPhotonCut> fEMCCuts;
+  // std::vector<PHOSPhotonCut> fPHOSCuts;
+  // std::vector<EMCPhotonCut> fEMCCuts;
 
   std::vector<std::string> fDetNames;
   void init(InitContext& context)
@@ -138,7 +138,7 @@ struct SinglePhotonMC {
     auto* list_gen = dynamic_cast<THashList*>(fMainList->FindObject("Generated"));
     o2::aod::pwgem::photon::histogram::DefineHistograms(list_gen, "Generated", "Photon");
 
-    for (auto& detname : fDetNames) {
+    for (const auto& detname : fDetNames) {
       LOGF(info, "Enabled detector = %s", detname.data());
 
       o2::aod::pwgem::photon::histogram::AddHistClass(list_ev, detname.data());

PWGEM/PhotonMeson/Tasks/TagAndProbe.cxx

@@ -162,7 +162,7 @@ struct TagAndProbe {
 
     // create sub lists first.
 
-    for (auto& pairname : fPairNames) {
+    for (const auto& pairname : fPairNames) {
       LOGF(info, "Enabled pairs = %s", pairname.data());
 
       THashList* list_ev_pair = o2::aod::pwgem::photon::histogram::AddHistClass(list_ev, pairname.data());